Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unit test "g.runtime.enableCSSParsing"; parseToRGB output type e… #6525

Closed
wants to merge 3 commits into from

Conversation

lulusir
Copy link
Contributor

@lulusir lulusir commented Nov 19, 2024

…rror

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change

修复单元测试
unit test "g.runtime.enableCSSParsing";
parseToRGB output type error;

@hustcc
Copy link
Member

hustcc commented Nov 19, 2024

还是没通过,本地是可以运行通过吗?

@lulusir
Copy link
Contributor Author

lulusir commented Nov 20, 2024

还是没通过,本地是可以运行通过吗?

修复了两个非snapshot的问题,这两个通过了
snapshot重新生成之后还是有部分会报错

@Aarebecca
Copy link
Contributor

问题链路比较长,需要先修复 g 的相关问题: antvis/G#1844
然后升级 @antv/component 后才能解决 G2 相关问题,会在: https://github.com/antvis/G2/pulls 解决

@hustcc
Copy link
Member

hustcc commented Dec 3, 2024

@lulusir 单测已经修复:#6508 。可以重新 rebase 一下目标分支,在提交一下。

@Aarebecca Aarebecca closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants