perf: remove visibilitychange event of behavior before destroy (#6326)

antvis · Sep 12, 2024 · 49d2b57 · 49d2b57
1 parent cfb133f
commit 49d2b57
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/packages/core/src/behavior/behaviorOption.ts b/packages/core/src/behavior/behaviorOption.ts
@@ -54,9 +54,10 @@ export default {
       graph.on(event, handler);
     });
     // To avoid the tabs switching makes the keydown related behaviors disable
-    document.addEventListener('visibilitychange', () => {
+    this.handleVisibilityChange = () => {
       this.keydown = false;
-    });
+    };
+    document.addEventListener('visibilitychange', this.handleVisibilityChange);
   },
 
   unbind(graph: IAbstractGraph) {
@@ -73,6 +74,7 @@ export default {
       graph.off(event, handler);
     });
     graph.get('canvas').set('draggable', draggable);
+    document.removeEventListener('visibilitychange', this.handleVisibilityChange);
   },
 
   get(val: string) {

diff --git a/packages/core/src/graph/controller/mode.ts b/packages/core/src/graph/controller/mode.ts
@@ -255,6 +255,10 @@ export default class ModeController {
   }
 
   public destroy() {
+    each(this.currentBehaves, behave => {
+      if (behave.delegate) behave.delegate.remove();
+      behave.unbind(this.graph);
+    });
     (this.graph as IAbstractGraph | null) = null;
     (this.modes as Modes | null) = null;
     (this.currentBehaves as IBehaviorOption[] | null) = null;