New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: composite shapes animation #5759

Merged

Aarebecca merged 1 commit into v5 from fix/animation

May 22, 2024

Contributor

yvonneyx commented May 21, 2024

重新组织代码以支持在自定义复合图形时能直接使用内置动画


          fix: fix composite shapes animation

7de46fe

Aarebecca reviewed

View reviewed changes

packages/g6/src/elements/shapes/base-shape.ts

+                 * Get the prefix pairs for composite shapes used to handle animation
+                 * @returns tuples array where each tuple contains a key corresponding to a method `get${key}Style` and its shape prefix
+                 */
+                protected get compositeShapes(): [string, string][] {

Contributor

Aarebecca May 21, 2024

可以在元素约定这里添加上这里的约定。

Aarebecca approved these changes

View reviewed changes

Aarebecca merged commit 68ee8e3 into v5

5 checks passed

Aarebecca deleted the fix/animation branch

May 22, 2024 02:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet