Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix exceptional canvas options when init in dev env #5788

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

Aarebecca
Copy link
Contributor

  • 修复开发环境异常的 Canvas 初始化参数

createGraphCanvas 被同时用于测试环境和开发环境的画布,测试环境在 node 中执行,因此需要传入 document 和 offscreenCanvas,但开发环境是在浏览器中执行,传入这两个参数会导致事件拾取异常。


  • Fixed abnormal Canvas initialization parameters in the development environment

createGraphCanvas is used as a canvas for both the test environment and the development environment. The test environment is executed in node, so it needs to pass document and offscreenCanvas, but the development environment is executed in the browser, passing these two parameters will cause an event pickup exception.

@Aarebecca Aarebecca changed the title fix: fix exceptional canvas options when init in node env fix: fix exceptional canvas options when init in dev env May 30, 2024
@Aarebecca Aarebecca merged commit 0982c1e into v5 May 30, 2024
5 checks passed
@Aarebecca Aarebecca deleted the fix/dev branch May 30, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants