fix(elements): fix edge arrow cannot display #5810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Aarebecca
commented
Jun 4, 2024
Aarebecca
commented
- 修复边上箭头在启用动画的情况下无法显示的问题
- Fixed an issue where side arrows could not be displayed when animation was enabled
|
截图变更是由于之前的逻辑中将边上属性全部传给箭头，其中 increasedLineWidthForHitTesting 属性会导致额外创建交互判定区域 |
Aarebecca
commented
Jun 4, 2024
| const key = this.upsert('key', Path, this.getKeyStyle(attributes), container); | ||
| this.drawArrow(attributes, 'start'); | ||
| this.drawArrow(attributes, 'end'); | ||
|
|
There was a problem hiding this comment.
主要修复点在这里，目的是在 onframe 过程中，不仅更新 keyShape，还将其箭头一并更新
yvonneyx
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.