Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: adjust export event #5812

Merged
merged 1 commit into from
Jun 4, 2024
Merged

refactor: adjust export event #5812

merged 1 commit into from
Jun 4, 2024

Conversation

Aarebecca
Copy link
Contributor

  • 调整事件名枚举值
  • Adjusts the event name enumeration value

调整前 / Before:

import { NodeEvent } from '@antv/g6';

graph.on(`node:${NodeEvent.CLICK}`, ( )=> { });

调整后 / After:

import { NodeEvent } from '@antv/g6';

graph.on(NodeEvent.CLICK, ( )=> { });

@hustcc
Copy link
Member

hustcc commented Jun 4, 2024

这个改动好，之前看着确实别扭！

@Aarebecca Aarebecca merged commit 13ce857 into v5 Jun 4, 2024
5 checks passed
@Aarebecca Aarebecca deleted the refactor/event branch June 4, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aarebecca @hustcc