Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(elements): set className instead of id of upsert #5813

Merged
merged 4 commits into from
Jun 4, 2024
Merged

refactor(elements): set className instead of id of upsert #5813

merged 4 commits into from
Jun 4, 2024

Conversation

Aarebecca
Copy link
Contributor

  • upsert 创建的图形设置 className 而不是 id
  • upsert creates shapes that set className instead of id

@hustcc
Copy link
Member

hustcc commented Jun 4, 2024

改成 classname 会不会查找的时候，有有查找的性能问题。

@hustcc hustcc merged commit fe2f634 into v5 Jun 4, 2024
3 checks passed
@hustcc hustcc deleted the refactor/base-shape branch June 4, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvonneyx yvonneyx yvonneyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aarebecca @hustcc @yvonneyx