Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: adjust folder strucure #6115

Merged
merged 4 commits into from
Aug 2, 2024
Merged

refactor: adjust folder strucure #6115

merged 4 commits into from
Aug 2, 2024

Conversation

Aarebecca
Copy link
Contributor

  • 调整测试目录结构

bugs 移至 unit 路径下
调整一些路径引用
@/src 引用调整为 @antv/g6

  • 解决 registry 目录循环引用问题

  • Adjust the test directory structure

bugs move to the unit path
Adjust some path references
Adjust @/src references to @antv/g6

  • Fix the registry directory circular reference problem

@hustcc
Copy link
Member

hustcc commented Aug 2, 2024

这个改是遇到什么问题吗?

bugs 不适合调整到 unit 中吧,还是建议和其他库保持一致,如果要改也是统一改。

@Aarebecca
Copy link
Contributor Author

这个改是遇到什么问题吗?

bugs 不适合调整到 unit 中吧,还是建议和其他库保持一致,如果要改也是统一改。

截图生成的路径比较奇怪,感觉不是很统一

image

@Aarebecca
Copy link
Contributor Author

Aarebecca commented Aug 2, 2024

@hustcc 我看了下 G/G2/L7 并没有关于 bugs 的相关测试用例目录,所以 G6 这边修改并不影响一致性

@hustcc
Copy link
Member

hustcc commented Aug 2, 2024

确实没有了,旧版本有的,G2 5.0 还没有怎么针对 issue 修 bug。这个截图的问题,是不是改截图生成的代码就好了。

因为 unit 目录中的代码基本是 src 目录代码一致的,再放一个 bugs 会不会奇怪?

@Aarebecca
Copy link
Contributor Author

确实没有了,旧版本有的,G2 5.0 还没有怎么针对 issue 修 bug。这个截图的问题,是不是改截图生成的代码就好了。

因为 unit 目录中的代码基本是 src 目录代码一致的,再放一个 bugs 会不会奇怪?

主要是生成的截图都放在 snapshots 下,与 unit 结构也是一一对应的,就显得 bugs 没地方放😂

@Aarebecca
Copy link
Contributor Author

@hustcc 现在 bugs 位于 tests 下,但生成的截图与 unit 下目录平级位于 snapshots

@Aarebecca Aarebecca merged commit d76be08 into v5 Aug 2, 2024
5 checks passed
@Aarebecca Aarebecca deleted the test/refactor branch August 2, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants