Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjust contextmenu onclick params to get element #6174

Merged
merged 1 commit into from
Aug 13, 2024
Merged

fix: adjust contextmenu onclick params to get element #6174

merged 1 commit into from
Aug 13, 2024

Conversation

yvonneyx
Copy link
Contributor

@yvonneyx yvonneyx commented Aug 12, 2024 •
edited
Loading

  • adjust contextmenu onclick params

before

 onClick?: (value: string, target: HTMLElement) => void;

after

 onClick?: (value: string, target: HTMLElement, current: Element) => void;

@Aarebecca
Copy link
Contributor

There are some users who use this parameter normally, and the necessity of this PR and its impact on users need to be considered.

@yvonneyx yvonneyx merged commit 2d4aabb into v5 Aug 13, 2024
5 checks passed
@yvonneyx yvonneyx deleted the fix/contextmenu branch August 13, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aarebecca Aarebecca Aarebecca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yvonneyx @Aarebecca