Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: adjust edge filter lens plugin options #6236

Merged
merged 4 commits into from
Aug 27, 2024
Merged

refactor: adjust edge filter lens plugin options #6236

merged 4 commits into from
Aug 27, 2024

Conversation

yvonneyx
Copy link
Contributor

  • Modify edge filter lens plugin options. Configuration naming to be consistent with fisheye

Change

{ scaleRByWheel?: boolean }

to

{ scaleRBy?:'wheel' | 'unset' }

@Aarebecca
Copy link
Contributor

Aarebecca commented Aug 26, 2024 •
edited
Loading

It is no need to have an option with "'unset'", because scaleRBy is optional.

@yvonneyx yvonneyx merged commit 6fc9a92 into v5 Aug 27, 2024
5 checks passed
@yvonneyx yvonneyx deleted the refactor/edge-filter branch August 27, 2024 03:21
@nerds-github nerds-github mentioned this pull request Oct 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aarebecca Aarebecca Aarebecca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yvonneyx @Aarebecca