refactor: html node support dx, dy #6237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hustcc
reviewed
Aug 26, 2024
| const [width, height] = this.getSize(attributes); | ||
| return { ...style, width, height }; | ||
| return { x: dx, y: dy, ...style, width, height }; |
There was a problem hiding this comment.
html 原子组件本身也有 xy 属性吧，所以应该传入的 x += dx 吧？
There was a problem hiding this comment.
key shape 的位置是相对于副容器的，他没有单独的位置，因此 x 都是 0，所以这里不需要 x += dx
hustcc
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In default, the origin position of the html node is the top left. Now the origin position can be offset by dx and dy. Add a demo of html node.