Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(elements): adjust the computation logic of combo #6275

Merged
merged 3 commits into from
Sep 5, 2024
Merged

refactor(elements): adjust the computation logic of combo #6275

merged 3 commits into from
Sep 5, 2024

Conversation

Aarebecca
Copy link
Contributor

After this adjustment, the computation logic of combo can be summarized as:

  1. If the combo has no children, use its position which is specified in the data style
  2. If the combo is collapsed, and its children have position specified in the data style, compute the average position of children nodes.
  3. Compute the position by the bounds box of children nodes

@Aarebecca Aarebecca force-pushed the refactor/element-combo-position branch from 0eebb67 to 3bffc55 Compare September 5, 2024 02:35
@Aarebecca Aarebecca force-pushed the refactor/element-combo-position branch from 3bffc55 to 32e53bf Compare September 5, 2024 02:44
@Aarebecca Aarebecca merged commit fb1626d into v5 Sep 5, 2024
5 checks passed
@Aarebecca Aarebecca deleted the refactor/element-combo-position branch September 5, 2024 03:17
@nerds-github nerds-github mentioned this pull request Oct 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Aarebecca