fix: enable filterable float32 feature in WebGPU #160

antvis · Jan 19, 2024 · fab40d0 · fab40d0
1 parent 5c06618
commit fab40d0
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/src/api/interfaces.ts b/src/api/interfaces.ts
@@ -482,6 +482,7 @@ export interface SamplerBinding {
 
 export enum SamplerFormatKind {
   Float,
+  UnfilterableFloat,
   Uint,
   Sint,
   Depth,

diff --git a/src/webgpu/WebGPUDeviceContribution.ts b/src/webgpu/WebGPUDeviceContribution.ts
@@ -36,6 +36,7 @@ export class WebGPUDeviceContribution implements DeviceContribution {
       // 'depth24unorm-stencil8',
       'depth32float-stencil8',
       'texture-compression-bc',
+      'float32-filterable',
     ];
     const requiredFeatures = optionalFeatures.filter((feature) =>
       adapter.features.has(feature),

diff --git a/src/webgpu/utils.ts b/src/webgpu/utils.ts
@@ -176,9 +176,16 @@ export function translateMipFilter(
   else throw new Error('whoops');
 }
 
+/**
+ * @see https://www.w3.org/TR/webgpu/#enumdef-gputexturesampletype
+ */
 function translateSampleType(type: SamplerFormatKind): GPUTextureSampleType {
   if (type === SamplerFormatKind.Float) return 'float';
+  else if (type === SamplerFormatKind.UnfilterableFloat)
+    return 'unfilterable-float';
   else if (type === SamplerFormatKind.Depth) return 'depth';
+  else if (type === SamplerFormatKind.Sint) return 'sint';
+  else if (type === SamplerFormatKind.Uint) return 'uint';
   else throw new Error('whoops');
 }