Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 增加 appendPadding 调节padding #2502

Merged
merged 8 commits into from
May 30, 2020
Merged

feat: 增加 appendPadding 调节padding #2502

merged 8 commits into from
May 30, 2020

Conversation

Leannechn
Copy link
Member

Checklist
  • [1 ] npm test passes
  • [1] tests and/or benchmarks are included
  • [1 ] commit message follows commit guidelines
Description of change

simaQ
simaQ previously approved these changes May 28, 2020
@simaQ
Copy link
Contributor

simaQ commented May 28, 2020

有冲突

src/chart/layout/index.ts Outdated Show resolved Hide resolved
src/util/bbox.ts Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented May 28, 2020

This pull request introduces 1 alert when merging bf9596d into 6097cf6 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented May 28, 2020

This pull request introduces 1 alert when merging 587f93b into 6097cf6 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented May 28, 2020

This pull request introduces 1 alert when merging 0720fd5 into 6097cf6 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

.interval()
.position('班级*人数')
.color('班级');
chart.interval().position('班级*人数').color('班级');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此处的修改,由于commit 的勾子触发编辑器自动格式化引起的变化。这个需修改commit的勾子。

@hustcc hustcc merged commit fe352ce into master May 30, 2020
@hustcc hustcc deleted the appendPadding branch May 30, 2020 01:40
@pr-triage pr-triage bot added the PR: merged label May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants