Add support for country subdivisions. #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To use a subdivision, specify country as COUNTRY:SUBDIVISION in your configuration file.
wolterhv
commented
Aug 8, 2024
| try: | ||
| import holidays as hl | ||
| from holidays import registry | ||
|
|
||
| (country, subdivision) = get_country_and_subdivision(country) |
There was a problem hiding this comment.
Prior to this line, country would be set to either something like UnitedKingdom or UnitedKingdom:England. After this line, country is redefined to UnitedKingdom and subdivision is defined as England.
|
Hi, thank you for the contribution! That looks pretty good. |
|
Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to implement quick and dirty support for country subdivisions. I've tested this for England (UK) and France, by setting
holiday_countryin myconfig.inifile toUnitedKingdom:England,France. As a result, I can see both holidays for England (UK) and for France.Feel free to make suggestions to better fit this code to the repository style and best practice. I acknowledge my solution is quick and dirty.