Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix incorrect dependency types #1648

Merged
merged 1 commit into from
Mar 15, 2022
Merged

refactor: fix incorrect dependency types #1648

merged 1 commit into from
Mar 15, 2022

Conversation

rickstaa
Copy link
Collaborator

As discussed in #712 axios should be labelled as a dependency while prettier should be labelled as a dev dependency. This Pull request solves this.

This commit makes sure that axios is labelled as a dependency and
prettier as a dev dependency.
@vercel
Copy link

vercel bot commented Mar 15, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/github-readme-stats-team/github-readme-stats/2XqSN2uA2zhjXXgPCAQbk69ProAQ
✅ Preview: https://github-readme-stats-git-fixdeps-github-readme-stats-team.vercel.app

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #1648 (e7f6c8a) into master (cae6c45) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1648   +/-   ##
=======================================
  Coverage   94.61%   94.61%           
=======================================
  Files          22       22           
  Lines         762      762           
  Branches      207      207           
=======================================
  Hits          721      721           
  Misses         36       36           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cae6c45...e7f6c8a. Read the comment docs.

@rickstaa rickstaa merged commit 104bdd6 into master Mar 15, 2022
@rickstaa rickstaa deleted the fix_deps branch March 15, 2022 21:18
Kab1r pushed a commit to Kab1r/github-readme-stats that referenced this pull request Apr 4, 2022
This commit makes sure that axios is labelled as a dependency and
prettier as a dev dependency.
lencx pushed a commit to lencx/github-readme-stats that referenced this pull request May 16, 2022
This commit makes sure that axios is labelled as a dependency and
prettier as a dev dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant