Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CACHE_SECONDS environment variable #2266

Merged
merged 3 commits into from
Jun 9, 2023

Conversation

rickstaa
Copy link
Collaborator

This commit adds the CACHE_SECONDS environment variable. This variable
can be used to circumvent our cache clamping values for self hosted
Vercel instances.

@vercel
Copy link

vercel bot commented Nov 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
github-readme-stats ✅ Ready (Inspect) Visit Preview Jun 8, 2023 8:15am

This commit adds the CACHE_SECONDS environment variable. This variable
can be used to circumvent our cache clamping values for self hosted
Vercel instances.
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (38c8a7a) 97.59% compared to head (39dd04a) 97.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2266   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files          24       24           
  Lines        4814     4823    +9     
  Branches      447      453    +6     
=======================================
+ Hits         4698     4707    +9     
  Misses        115      115           
  Partials        1        1           
Impacted Files Coverage Δ
api/index.js 96.15% <100.00%> (+0.11%) ⬆️
api/pin.js 93.25% <100.00%> (+0.23%) ⬆️
api/top-langs.js 96.19% <100.00%> (+0.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rickstaa
Copy link
Collaborator Author

@anuraghazra I think this one is good to be merged. It is a small PR allowing users to overwrite the CACHE_SECONDS behaviour in their Vercel Instance.

Copy link
Collaborator

@qwerty541 qwerty541 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @rickstaa! I think that it will be nice to merge this pull request next. If you resolve conflicts i will approve it.

@github-actions github-actions bot added the documentation Improvements or additions to documentation. label Jun 8, 2023
@rickstaa rickstaa force-pushed the add_cache_seconds_env_variable branch from c8756dc to ac0818f Compare June 8, 2023 08:10
@rickstaa
Copy link
Collaborator Author

rickstaa commented Jun 8, 2023

@qwerty541 Great thanks! I just updated the README and resolved the conflicts 👍🏻.

@qwerty541 qwerty541 merged commit 3e66189 into master Jun 9, 2023
@rickstaa rickstaa deleted the add_cache_seconds_env_variable branch June 9, 2023 05:42
j4ckofalltrades pushed a commit to j4ckofalltrades/gh-stats that referenced this pull request Jun 10, 2023
* feat: add CACHE_SECONDS environment variable (anuraghazra#2266)

* feat: add CACHE_SECONDS environment variable

This commit adds the CACHE_SECONDS environment variable. This variable
can be used to circumvent our cache clamping values for self hosted
Vercel instances.

* refactor: apply formatter

* Remove redundant ask for theme screenshot from CONTRIBUTING.md (anuraghazra#2797)

* Fix clampValue function docstring (anuraghazra#2796)

* Docs: add warning about top languages card behavior. (anuraghazra#2789)

* Docs: add warning about top languages card behavior.

* dev

* dev

* Update readme.md about maxDuration (anuraghazra#2792)

* Update readme.md about maxDuration

I think we can remove this warning section since that value in  `.json` has been changed to 10 by default nowadays?

* Update readme.md

remove related section in self deployment section as well

* docs: add inverse maxDuration warning

---------

Co-authored-by: rickstaa <rick.staa@outlook.com>

* docs: add package debug steps to contribution guidelines (anuraghazra#2798)

* Beautify themes contribution note inside CONTRIBUTING.md (anuraghazra#2800)

---------

Co-authored-by: Rick Staa <rick.staa@outlook.com>
Co-authored-by: Alexandr Garbuzov <qwerty541zxc@gmail.com>
Co-authored-by: しぐれ <23041178+ForsakenRei@users.noreply.github.com>
devantler pushed a commit to devantler/github-readme-stats that referenced this pull request Sep 24, 2023
* feat: add CACHE_SECONDS environment variable

This commit adds the CACHE_SECONDS environment variable. This variable
can be used to circumvent our cache clamping values for self hosted
Vercel instances.

* refactor: apply formatter
setdebarr pushed a commit to setdebarr/github-readme-stats that referenced this pull request Jan 12, 2024
* feat: add CACHE_SECONDS environment variable

This commit adds the CACHE_SECONDS environment variable. This variable
can be used to circumvent our cache clamping values for self hosted
Vercel instances.

* refactor: apply formatter
jacobbexten pushed a commit to jacobbexten/github-readme-stats that referenced this pull request Nov 6, 2024
* feat: add CACHE_SECONDS environment variable

This commit adds the CACHE_SECONDS environment variable. This variable
can be used to circumvent our cache clamping values for self hosted
Vercel instances.

* refactor: apply formatter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants