-
-
Notifications
You must be signed in to change notification settings - Fork 23.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add CACHE_SECONDS environment variable #2266
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This commit adds the CACHE_SECONDS environment variable. This variable can be used to circumvent our cache clamping values for self hosted Vercel instances.
9145458
to
c7a15e5
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2266 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 24 24
Lines 4814 4823 +9
Branches 447 453 +6
=======================================
+ Hits 4698 4707 +9
Misses 115 115
Partials 1 1
☔ View full report in Codecov by Sentry. |
e18b78b
to
ac95c74
Compare
@anuraghazra I think this one is good to be merged. It is a small PR allowing users to overwrite the CACHE_SECONDS behaviour in their Vercel Instance. |
ac95c74
to
5ea236c
Compare
86aafe8
to
8bc69e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @rickstaa! I think that it will be nice to merge this pull request next. If you resolve conflicts i will approve it.
c8756dc
to
ac0818f
Compare
ac0818f
to
39dd04a
Compare
@qwerty541 Great thanks! I just updated the README and resolved the conflicts 👍🏻. |
* feat: add CACHE_SECONDS environment variable (anuraghazra#2266) * feat: add CACHE_SECONDS environment variable This commit adds the CACHE_SECONDS environment variable. This variable can be used to circumvent our cache clamping values for self hosted Vercel instances. * refactor: apply formatter * Remove redundant ask for theme screenshot from CONTRIBUTING.md (anuraghazra#2797) * Fix clampValue function docstring (anuraghazra#2796) * Docs: add warning about top languages card behavior. (anuraghazra#2789) * Docs: add warning about top languages card behavior. * dev * dev * Update readme.md about maxDuration (anuraghazra#2792) * Update readme.md about maxDuration I think we can remove this warning section since that value in `.json` has been changed to 10 by default nowadays? * Update readme.md remove related section in self deployment section as well * docs: add inverse maxDuration warning --------- Co-authored-by: rickstaa <rick.staa@outlook.com> * docs: add package debug steps to contribution guidelines (anuraghazra#2798) * Beautify themes contribution note inside CONTRIBUTING.md (anuraghazra#2800) --------- Co-authored-by: Rick Staa <rick.staa@outlook.com> Co-authored-by: Alexandr Garbuzov <qwerty541zxc@gmail.com> Co-authored-by: しぐれ <23041178+ForsakenRei@users.noreply.github.com>
* feat: add CACHE_SECONDS environment variable This commit adds the CACHE_SECONDS environment variable. This variable can be used to circumvent our cache clamping values for self hosted Vercel instances. * refactor: apply formatter
* feat: add CACHE_SECONDS environment variable This commit adds the CACHE_SECONDS environment variable. This variable can be used to circumvent our cache clamping values for self hosted Vercel instances. * refactor: apply formatter
* feat: add CACHE_SECONDS environment variable This commit adds the CACHE_SECONDS environment variable. This variable can be used to circumvent our cache clamping values for self hosted Vercel instances. * refactor: apply formatter
This commit adds the CACHE_SECONDS environment variable. This variable
can be used to circumvent our cache clamping values for self hosted
Vercel instances.