Address codereview comments

anush-apple · Jan 25, 2024 · 1770f1f · 1770f1f
1 parent b690c78
commit 1770f1f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/examples/darwin-framework-tool/BUILD.gn b/examples/darwin-framework-tool/BUILD.gn
@@ -43,8 +43,8 @@ declare_args() {
 
   enable_provisional_features = config_enable_yaml_tests
 
-  # Enable generating compiler database
-  gen_compdb = false
+  # Disable generating compiler database by default
+  generate_compilation_database = false
 }
 
 sdk = "macosx"
@@ -110,7 +110,7 @@ action("build-darwin-framework") {
     args += [ "--no-clang" ]
   }
 
-  if (defined(gen_compdb) && gen_compdb) {
+  if (generate_compilation_database) {
     args += [ "--compdb" ]
   } else {
     args += [ "--no-compdb" ]

diff --git a/scripts/helpers/generate_darwin_compdb.sh b/scripts/helpers/generate_darwin_compdb.sh
@@ -29,7 +29,7 @@ CHIP_ROOT="$(dirname "$0")/../.."
 OUTPUT_DIR=$2
 
 # Build the framework
-scripts/examples/gn_build_example.sh $@ gen_compdb=true
+scripts/examples/gn_build_example.sh $@ generate_compilation_database=true
 
 # Cleanup any stale DB files
 find $OUTPUT_DIR -iname compile_commands\*.json | xargs rm