Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compression state flushed when switching encoding #109

Closed
any1 opened this issue Feb 1, 2024 · 0 comments
Closed

Compression state flushed when switching encoding #109

any1 opened this issue Feb 1, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@any1
Copy link
Owner

any1 commented Feb 1, 2024

Clients expect zlib streams to be preserved when switching encodings.

This is what causes the the RealVNC client to fail to connect sometimes. The screen flickers a bit and it shows some Zlib error. It happens because it switches between ZRLE and raw while starting up, possibly for trying to figure out which is faster.

This is also a problem for ZRLE, but H264 should be fine because it will always send a key-frame after a new encoder has been allocated.
@any1 any1 added the bug Something isn't working label Feb 1, 2024
@any1 any1 closed this as completed in c7d7929 Feb 2, 2024
any1 added a commit that referenced this issue Feb 2, 2024
@any1
Keep zlib streams when switching encodings
a77ff63 
Both RealVNC and TigerVNC clients expect zlib streams to remain when
switching encodings, so when they switch back, inflate fails if the
encoder is discared.

fixes #109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@any1