Adapt C++ code styling #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
romangg
commented
Sep 8, 2024
romangg
commented
- Use clang-format 18
- Check clang-format on the whole repo in CI
- Change C++ code styling in multiple aspects
While the Docker container at the moment runs with clang 17, we can prepare already the update to 18 for clang-format as the CI runs with any version.
No need to limit the check. This way also the dbcli.cpp file is checked and potentially other files in other subdirectories in the future.
This changes the code style in multiple ways. In particular: - increase column limit from 80 to 100 - increase vertical space usage with braces - right qualifier alignement (east const) - sort includes case insensitvely
This was done via clang-format's InsertBraces option. The option is not added permanently though since clang-format doesn't know about the code semantics and later changes might introduce regresssions. To control braces in the future we should use clang-tidy's readability-braces-around-statements check instead.
LordTermor
added
Daemon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.