Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor db-cli #152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor db-cli #152

wants to merge 1 commit into from

Conversation

LordTermor
Copy link
Collaborator

  • Introduced a new db-cli tool structure with better modularization
  • Added a Validator class for improved error handling
  • Added CLI11 to handle command line arguments

@LordTermor LordTermor self-assigned this Nov 24, 2024
@LordTermor
refactor(db-cli): improve database CLI structure
89b27da 
- Introduced a new db-cli tool structure with better modularization
- Added a Validator class for improved error handling
- Added CLI11 to handle command line arguments
@LordTermor LordTermor added enhancement New feature or request Refactoring Readability code changes labels Nov 24, 2024
romangg
romangg approved these changes Dec 1, 2024
View reviewed changes
Copy link
Contributor

@romangg romangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You basically rewrote everything, so a diff probably wouldn't give a lot of info anyway, but still: rewriting code and renaming files in the same commit makes it difficult to follow changes in the log in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romangg romangg romangg approved these changes

Assignees

@LordTermor LordTermor

Labels
enhancement New feature or request Refactoring Readability code changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LordTermor @romangg