Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caddy support #29

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Caddy support #29

merged 3 commits into from
Apr 25, 2024

Conversation

LordTermor
Copy link
Collaborator

Updates docker-compose and CD workflow to support caddy reverse proxy

@LordTermor LordTermor marked this pull request as draft April 19, 2024 17:51
@LordTermor LordTermor marked this pull request as ready for review April 23, 2024 17:44
@romangg
Copy link
Contributor

romangg commented Apr 24, 2024

The first two commits could be combined. The first commit is useless without the second from a functional perspective. In the third commit why do you use the compose plugin now in CLI? A short comment in the commit message would help me/us understand the decision better down the line.

Regarding your commit messages: conventional commits requires lower-case letter after the type(scope):. Not a big one though.

@LordTermor
Copy link
Collaborator Author

The first two commits could be combined. The first commit is useless without the second from a functional perspective.

Caddy docker-compose file can be used independently of CD routine that's why I separated them.

In the third commit why do you use the compose plugin now in CLI?

It seems the compose as a CLI plugin has a newer version than docker-compose utility in CI environment.

@LordTermor LordTermor merged commit 104f5fd into anydistro:master Apr 25, 2024
4 checks passed
@LordTermor LordTermor deleted the caddy-support branch May 25, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants