Sync improvements #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordTermor
added
bug
LordTermor
force-pushed
the
sync-improvements
branch
from
da87461
to
e063c2d
Compare
This was
linked to
issues
May 24, 2024
Closed
romangg
reviewed
May 24, 2024
dbcli/dbcli.cpp
Outdated
|
|
||
| int main(int argc, char** argv) { | ||
| auto lmdbenv = std::make_shared<bxt::Utilities::LMDB::Environment>( | ||
| std::make_shared<coro::io_scheduler>()); |
There was a problem hiding this comment.
Are these shared pointer necessary? Value types are when possible preferable.
There was a problem hiding this comment.
LMDB's Enviroment is indeed intended to be used with a shared global io_scheduler (to manage transactions and concurrency) and also be shared with DBs itself for the same purpose, that's why it's needed.
In this particular case this doesn't really make sense but I just reused the daemon's components. I can rewrite using plain LMDB(++) if preferable.
Will do, boss. |
LordTermor
force-pushed
the
sync-improvements
branch
from
e063c2d
to
a363d5a
Compare
Implements a basic database CLI for looking through the LMDB
Drastically improves sync service, including: - The service now retries failed downloads and has a connection timeout - Improved error handling and logging on all steps - Use scope guard for event dispatching on errors
- Templated hash functions - More verbose variables
Async synchronization needs more testing.
LordTermor
force-pushed
the
sync-improvements
branch
from
a363d5a
to
7189886
Compare
romangg
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves overall previously half-baked sync service. It also includes
dbclidev utility to look through the LMDB packages database+in package version)Those all are somewhat connected to the sync process but other subsystems will benefit as well.