fix: improve isurl regex #1032
Merged
fix: improve isurl regex #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
melloware
force-pushed
the
fix__use_require_tld_instead_of_regex
branch
from
684bcd7 to
bec2e1f
Compare
melloware
requested review from
anymaniax,
AntoinePaques,
codebutler,
EwenQuim and
Marcel-G
alanpoulain
reviewed
Nov 10, 2023
melloware
force-pushed
the
fix__use_require_tld_instead_of_regex
branch
3 times, most recently
from
53009e2 to
e72b7f9
Compare
|
Can someone review this. The build is currently broken until this fix is implemented. |
alanpoulain
reviewed
Nov 13, 2023
melloware
force-pushed
the
fix__use_require_tld_instead_of_regex
branch
from
e72b7f9 to
feded76
Compare
melloware
force-pushed
the
fix__use_require_tld_instead_of_regex
branch
from
feded76 to
b95397c
Compare
Will-Mann-16
approved these changes
Nov 13, 2023
anymaniax
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves on #920 and adds unit tests
Ensures that new scenario and old scenarios are still all working so we don't keep breaking this.
according to Snyk this is the correct way to detect a URL: https://snyk.io/blog/secure-javascript-url-validation/