Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(axios): ignore commented out lines #1031

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

melloware
Copy link
Collaborator

@melloware melloware commented Nov 10, 2023

Status

*READY

Description

Strips comments out of mutator file before processing.

Fix #673

Regex101: https://regex101.com/r/P77HnT/1

@melloware melloware added the bug Something isn't working label Nov 10, 2023
@melloware
Copy link
Collaborator Author

Waiting on fix #1032 for tests to pass.

@melloware melloware added this to the 6.21.0 milestone Nov 10, 2023
Copy link
Contributor

@EwenQuim EwenQuim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some testing. Regular expressions can sometimes be surprisingly wild

@melloware
Copy link
Collaborator Author

Here is a regex101 tester if you want to play around with it: https://regex101.com/r/P77HnT/1

@melloware melloware merged commit 4430193 into orval-labs:master Nov 13, 2023
@melloware melloware deleted the PO673-comments2 branch November 13, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Axios: Mutator is parsing commented out lines
3 participants