After review changes

anyproto · Aug 13, 2024 · 78ddad7 · 78ddad7
1 parent 8629939
commit 78ddad7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/coordinator/coordinator.go b/coordinator/coordinator.go
@@ -445,6 +445,9 @@ func (c *coordinator) MakeSpaceUnshareable(ctx context.Context, spaceId, aclHead
 	}
 
 	err = c.spaceStatus.MakeUnshareable(ctx, spaceId)
+	if err != nil {
+		return
+	}
 
 	return c.aclEventLog.AddLog(ctx, acleventlog.AclEventLogEntry{
 		SpaceId:   spaceId,

diff --git a/coordinator/rpchandler.go b/coordinator/rpchandler.go
@@ -450,13 +450,6 @@ func (r *rpcHandler) AclEventLog(ctx context.Context, req *coordinatorproto.AclE
 			Type:      t,
 		})
 
-		// add additional fields for some record types
-
-		// TODO: copy SignedSpaceReceipt field, protos does not have it yet
-		// if rec.EntryType == acleventlog.EntryTypeSpaceReceipt {
-		//	resp.Records[len(resp.Records)-1].SignedSpaceReceipt = rec.SignedSpaceReceipt
-		// }
-
 		if rec.EntryType == acleventlog.EntryTypeSpaceAclAddRecord {
 			resp.Records[len(resp.Records)-1].AclChangeId = rec.AclChangeId
 		}