Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: new coordinator API - EventLog #82

Closed
wants to merge 1 commit into from
Closed

Conversation

AnthonyAkentiev
Copy link
Contributor

@AnthonyAkentiev AnthonyAkentiev commented Aug 8, 2024


  • I understand that contributing to this repository will require me to agree with the CLA

Description

Please see the task description here.

Implementation details:

  • I've changed CoordinatorLog.SpaceReceipt to more generic CoordinatorLog.AddLog
  • Coordinator log item now has new EntryType field
  • But still without additional data for ACLs, etc! (still WiP)
  • I've added new EventLog() method to rpchandlers.go which can enumerate items in the EventLog

TODOs:

  • Add additional data for "EntryTypeSpaceAclAddRecord" type of record
  • Add more tests

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 tech-docs
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant