Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update file node configuration to provide S3 credentials and force path style #22

Merged
merged 2 commits into from
Aug 7, 2023
Merged

update file node configuration to provide S3 credentials and force path style #22

merged 2 commits into from
Aug 7, 2023

Commits on Aug 5, 2023

  1. add keys in file node configuration to provide S3 credentials 

    for self-hosted use cases, users might use an S3-compatible service like
MinIO. This service requires authentication using access keys however it
does not really make sense for users to create an AWS configuration on
the machine since there is no AWS account involved.

Moreover, for using MinIO, path style is mandatory unless users setup
some kind of DNS resolution for their buckets. I think it is best to
avoid this complication and simply force the path style with the related
option in the AWS SDK.
    @clems4ever
    clems4ever committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    e945148 View commit details
    Browse the repository at this point in the history

  2. remove useless nil

    @clems4ever
    clems4ever committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    6f04479 View commit details
    Browse the repository at this point in the history