Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a flag to generate a network configuration with defaults #7

Closed
wants to merge 3 commits into from
Closed

add a flag to generate a network configuration with defaults #7

wants to merge 3 commits into from

Commits on Aug 5, 2023

  1. add a flag to generate a network configuration with defaults 

    the cli for generating network configurations is using the survey
library for generating the configurations. However, this library does
not support stdin as IO as described in
https://github.com/go-survey/survey#what-kinds-of-io-are-supported-by-survey.

This is a problem for automating the generation of configuration for
creating a docker based setup. We would rather not use static keys as
done in https://github.com/SamBouwer/any-docker because if by any bad
luck the local setup is broken and starts to sync data on the public
backup node instead of the local one, this could lead to serious
troubles for the data, since the keys are public.

To avoid that situation, the cli should rather have a way to generate
the configuration with default network values mainly for generating the
security keys and leave it to the user to then further update the
configurations as necessary. This only works for one node but in the
case of self-hosted I think it is good enough for now.

Also, an alternative solution would have been to replace the survey
library to use something able to read from stdin but this would be more
intrusive and would have more potential for bugs after the change hence
my proposal to introduce a simple --defaults flag to the command.
    @clems4ever
    clems4ever committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    d44f894 View commit details
    Browse the repository at this point in the history

  2. fixes release.yml and update the cli readme

    @clems4ever
    clems4ever committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    f855ea0 View commit details
    Browse the repository at this point in the history

  3. rename ci job

    @clems4ever
    clems4ever committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    ba6a187 View commit details
    Browse the repository at this point in the history