Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GO-1751: Remove common storage #302

Merged
merged 2 commits into from
Sep 30, 2024
Merged

GO-1751: Remove common storage #302

merged 2 commits into from
Sep 30, 2024

Conversation

mcrakhman
Copy link
Contributor

  • I understand that contributing to this repository will require me to agree with the CLA

Description

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 tech-docs
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

New Coverage 62.6% of statements
Patch Coverage 80.0% of changed statements (12/15)

Coverage provided by https://github.com/seriousben/go-patch-cover-action

@zarkone
Copy link
Contributor

zarkone commented Sep 24, 2024

dependency of anyproto/any-sync-node#110

@mcrakhman mcrakhman merged commit 84cf034 into main Sep 30, 2024
4 checks passed
@mcrakhman mcrakhman deleted the GO-1751-remove-common-storage branch September 30, 2024 14:21
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zarkone zarkone zarkone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcrakhman @zarkone