GO-4017 Set imageKind on file upload #1596
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage provided by https://github.com/seriousben/go-patch-cover-action |
| ) | ||
|
|
||
| type BlockService interface { | ||
| GetObject(ctx context.Context, objectID string) (sb smartblock.SmartBlock, err error) | ||
| GetObjectByFullID(ctx context.Context, id domain.FullID) (sb smartblock.SmartBlock, err error) | ||
| UploadFile(ctx context.Context, spaceId string, req block.FileUploadRequest) (objectId string, details *types.Struct, err error) | ||
| UploadFileBlock(contextID string, req block.UploadRequest) (fileObjectId string, err error) | ||
| UploadBlockFile(ctx session.Context, req block.UploadRequest, groupID string, isSync bool) (fileObjectId string, err error) |
There was a problem hiding this comment.
Seems like ctx is always nil, when you call UploadBlockFile. May be we should remove it? 🧐
There was a problem hiding this comment.
Yeah, I agree with you! Let me fix that
There was a problem hiding this comment.
Basically, I have decided to propagate session.ctx in couple of file uploading commands
fat-fellow
approved these changes
Sep 22, 2024
AnastasiaShemyakinskaya
approved these changes
Sep 23, 2024
AnastasiaShemyakinskaya
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/anytype/issue/GO-4017/clipboard-html-files-should-be-hidden-by-default