GO-3753 Add write to file #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage provided by https://github.com/seriousben/go-patch-cover-action |
fat-fellow
force-pushed
the
go-3753-write-logs-to-file
branch
3 times, most recently
from
b61e969
to
c43bf87
Compare
fat-fellow
commented
Sep 30, 2024
pkg/lib/global/global.go
Outdated
| @@ -0,0 +1,4 @@ | |||
| package global | |||
There was a problem hiding this comment.
should we choose a different name? common? shared?
root/
fat-fellow
commented
Sep 30, 2024
| message SetParameters { | ||
| message Request { | ||
| option (no_auth) = true; | ||
| string platform = 1; | ||
| string version = 2; | ||
| string workdir = 3; | ||
| string logLevel = 4; | ||
| bool doNotSendLogs = 5; |
There was a problem hiding this comment.
because we want to send logs by default
fat-fellow
force-pushed
the
go-3753-write-logs-to-file
branch
from
c43bf87
to
c694eac
Compare
fat-fellow
commented
Sep 30, 2024
core/metrics.go
Outdated
| func (mw *Middleware) MetricsSetParameters(cctx context.Context, req *pb.RpcMetricsSetParametersRequest) *pb.RpcMetricsSetParametersResponse { | ||
| response := func(code pb.RpcMetricsSetParametersResponseErrorCode, err error) *pb.RpcMetricsSetParametersResponse { | ||
| m := &pb.RpcMetricsSetParametersResponse{Error: &pb.RpcMetricsSetParametersResponseError{Code: code}} | ||
| func (mw *Middleware) SetInitialParams(cctx context.Context, req *pb.RpcInitialSetParametersRequest) *pb.RpcInitialSetParametersResponse { |
There was a problem hiding this comment.
instead of setmetricsparams
fat-fellow
commented
Sep 30, 2024
core/metrics.go
Outdated
| errors.New("version is empty. Version must be in format: 1.0.0-optional-commit-hash-for-dev-builds")) | ||
| } | ||
| mw.applicationService.SetClientVersion(req.Platform, req.Version) | ||
|
|
||
| metrics.Service.SetPlatform(req.Platform) | ||
| metrics.Service.SetStartVersion(req.Version) | ||
| logging.Init(req.Workdir, req.LogLevel, !req.DoNotSendLogs) |
There was a problem hiding this comment.
if workdir is empty we don't write the logs
if loglevel is empty we use defaultlog levels
if donotsend we don't send gelf
fat-fellow
force-pushed
the
go-3753-write-logs-to-file
branch
2 times, most recently
from
c443bd9
to
4060d85
Compare
fat-fellow
force-pushed
the
go-3753-write-logs-to-file
branch
4 times, most recently
from
46b837d
to
6a92ccb
Compare
deff7
approved these changes
Oct 2, 2024
fat-fellow
force-pushed
the
go-3753-write-logs-to-file
branch
3 times, most recently
from
4f17f5d
to
fdb5187
Compare
Add an opt-out for gelf Add an opt-out for telemetry
fat-fellow
force-pushed
the
go-3753-write-logs-to-file
branch
from
fdb5187
to
776e333
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?