Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate server-side code for error return types #63

Open
gkanz opened this issue Apr 1, 2020 · 0 comments
Open

Generate server-side code for error return types #63

gkanz opened this issue Apr 1, 2020 · 0 comments
Assignees
Labels
P1 Medium priority

Comments

@gkanz
Copy link
Contributor

gkanz commented Apr 1, 2020

Currently, return error <: ErrorType is handled by svc_client.sysl, but not by svc_handler.sysl. Errors returned by the generated server are forced to be of type:

type HTTPError struct {
	HTTPCode    int    `json:"-"`
	Code        string `json:"code,omitempty"`
	Description string `json:"description,omitempty"`
}

svc_handler.sysl should be updated to allow sysl-specified error types to be returned by the server.

@gkanz gkanz self-assigned this Apr 2, 2020
@ChloePlanet ChloePlanet added P0 Highest priority: important and urgent P1 Medium priority and removed P0 Highest priority: important and urgent labels Apr 8, 2020
ChloePlanet pushed a commit that referenced this issue Oct 8, 2020
experimental -- remove serverParams.Serve abstraction so core.Serve can access logger
andrewemeryanz pushed a commit that referenced this issue Jun 2, 2021
experimental -- remove serverParams.Serve abstraction so core.Serve can access logger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority
Projects
None yet
Development

No branches or pull requests

2 participants