Fix generated JsonDesererialzer Java code errors #75
Conversation
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
=======================================
Coverage 57.39% 57.39%
=======================================
Files 36 36
Lines 7037 7037
=======================================
Hits 4039 4039
Misses 2998 2998
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
LGTM with whitespace changes.
BTW, this was made hard to review because I had to reverse engineer the issue. The PR and commit do not reference the issue, though I found it from the test article.sysl file. The issue didn't really explain the problem and what the solution should be. The function java.CamelCase just capitalises the first letter of the word, which is not camel casing (being camel case says nothing about the case of the first letter, just how words are joined into a single symbol).
In the end, I figured out the nature of the problem so I can see how the code you wrote addresses it, but that info should be recorded somewhere.
| } | ||
|
|
||
| public static Article articleFromJson() throws IOException { | ||
| JsonFactory factory = new JsonFactory(); |
There was a problem hiding this comment.
The indenting has gone funny in this method - tabs vs spaces?
There was a problem hiding this comment.
Done, thanks. I run into this quite regularly - I think it's when I copypasta from somewhere else. Do you have a tool that you run to avoid such issues or should I just see if I can change something in my editor?
| public static Article articleFromJson() throws IOException { | ||
| JsonFactory factory = new JsonFactory(); | ||
| String s = "{\"content\" : { \"Text\" : \"Peace and love\" } }"; | ||
| JsonParser p = factory.createParser(s); |
There was a problem hiding this comment.
nit: there's a double space before the =
|
So I was wrong about the PR not referencing the the issue - there it is right up front. I guess I missed it because I go straight to the commits. I'll pay more attention next time. |
Fixes #66.
Changes proposed in this pull request:
@anz-bank/sysl-developers