-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor importers to use an interface #904
Merged
cuminandpaprika
merged 13 commits into
anz-bank:master
from
cuminandpaprika:jack/importer-interface
Jun 29, 2020
Merged
Refactor importers to use an interface #904
cuminandpaprika
merged 13 commits into
anz-bank:master
from
cuminandpaprika:jack/importer-interface
Jun 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #904 +/- ##
==========================================
- Coverage 83.35% 83.32% -0.04%
==========================================
Files 73 75 +2
Lines 10609 10738 +129
==========================================
+ Hits 8843 8947 +104
- Misses 1432 1451 +19
- Partials 334 340 +6
|
cuminandpaprika
force-pushed
the
jack/importer-interface
branch
from
June 18, 2020 07:50
3ba0db0
to
fdb830c
Compare
ChloePlanet
approved these changes
Jun 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
GuessFileType is intended to replace all the format parsing and guessing which occurs in multiple places throughout the sysl codebase. This attempts to isolate it in a single file.
Adds an Importer interface that improves the modularity of each importer supported by Sysl
Adds a deprecation message to the format flag but keeps it there so it doesn't break existing users of sysl, giving them a chance to remove it from their files.
Keeps OpenAPI3 as a consistent way to reference openapi 3
cuminandpaprika
force-pushed
the
jack/importer-interface
branch
from
June 28, 2020 23:56
fdb830c
to
3fa23f9
Compare
anzopensource
pushed a commit
that referenced
this pull request
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly large PR that refactors the way that importers are called and removes the mode flag from the sysl import command. All file formats are now automatically detected. A warning message will now be presented if the flag is passed in.
This PR is best reviewed commit by commit.
Changes proposed in this pull request:
Checklist: