Skip to content

Commit

Permalink
Add entry to changelog
Browse files Browse the repository at this point in the history
Also tweak the wording in warning message, including the specific
mention of deprecation version
  • Loading branch information
steviez committed Jun 27, 2024
1 parent 653c59d commit c66f207
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ Release channels have their own copy of this changelog:
* Partitions are recalculated on boot from snapshot (#1159)
* `epoch_rewards_status` removed from snapshot (#1274)
* Added `unified-scheduler` option for `--block-verification-method` (#1668)
* Deprecate the `fifo` option for `--rocksdb-shred-compaction` (#1882)
* `fifo` will remain supported in v2.0 with plans to fully remove in v2.1

## [1.18.0]
* Changes
Expand Down
10 changes: 5 additions & 5 deletions validator/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1775,11 +1775,11 @@ pub fn main() {
"fifo" => {
warn!(
"The value \"fifo\" for --rocksdb-shred-compaction has been deprecated. \
Use of \"fifo\" will still work for now, but will be completely removed \
in the future. To update, use \"level\" for --rocksdb-shred-compaction, \
or remove the --rocksdb-shred-compaction argument altogether. Note that \
the \"rocksdb_fifo\" subdirectory within the ledger directory will need \
to be manually cleaned up once the validator is running with \"level\"."
Use of \"fifo\" will still work for now, but is planned for full removal \
in v2.1. To update, use \"level\" for --rocksdb-shred-compaction, or \
remove the --rocksdb-shred-compaction argument altogether. Note that the \
entire \"rocksdb_fifo\" subdirectory within the ledger directory will \
need to be manually removed once the validator is running with \"level\"."
);
match matches.value_of("rocksdb_fifo_shred_storage_size") {
None => ShredStorageType::rocks_fifo(default_fifo_shred_storage_size(
Expand Down

0 comments on commit c66f207

Please sign in to comment.