Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.18: load balance by CUs (backport of #1221) #1263

Closed
wants to merge 1 commit into from
Closed

v1.18: load balance by CUs (backport of #1221) #1263

wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 9, 2024

Problem

  • Current load balancing is done by transaction count
  • This leads to unbalanced loads across the threads
  • Until Scheduler - prioritization fees/cost solana-labs/solana#34888 CUs were totally innaccurate. However, in recent epochs with the prioritization change, the top scheduled txs are showing significantly more accurate estimates

Summary of Changes

  • Use CUs to load-balance across threads

Fixes #

This is an automatic backport of pull request #1221 done by [Mergify](https://mergify.com).

@apfitzge @mergify
load balance by CUs (#1221)
99df085 
(cherry picked from commit 41e2c96)
@mergify mergify bot requested review from a team as code owners May 9, 2024 16:09
@apfitzge apfitzge requested a review from tao-stones May 9, 2024 16:14
tao-stones
tao-stones approved these changes May 9, 2024
View reviewed changes
Copy link

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@willhickey
Copy link

Closing this as stale. If you think this is relevant please re-open and let @anza-xyz/backport-reviewers know why it is important

@willhickey willhickey closed this Sep 4, 2024
@mergify mergify bot deleted the mergify/bp/v1.18/pr-1221 branch September 4, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao-stones tao-stones tao-stones approved these changes

Assignees

@apfitzge apfitzge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willhickey @tao-stones @apfitzge