Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add precompile signature metrics to cost tracker #133

Merged

Conversation

tao-stones
Copy link

Problem

No metrics counter for precomplied signatures

Summary of Changes

  • add metrics to cost tracker

Fixes #

Copy link

mergify bot commented Mar 7, 2024

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

Copy link

mergify bot commented Mar 7, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@tao-stones tao-stones added the automerge automerge Merge this Pull Request automatically once CI passes label Mar 7, 2024
@mergify mergify bot merged commit 9770cd9 into anza-xyz:master Mar 8, 2024
48 checks passed
mergify bot pushed a commit that referenced this pull request Mar 8, 2024
(cherry picked from commit 9770cd9)

# Conflicts:
#	cost-model/src/cost_model.rs
#	cost-model/src/cost_tracker.rs
mergify bot pushed a commit that referenced this pull request Mar 8, 2024
@tao-stones tao-stones deleted the add-precompile-signautre-metrics branch March 8, 2024 03:09
tao-stones added a commit that referenced this pull request Mar 12, 2024
…133) (#143)

* add precompile signature metrics to cost tracker (#133)

(cherry picked from commit 9770cd9)

* merge fix

* fmt

---------

Co-authored-by: Tao Zhu <82401714+tao-stones@users.noreply.github.com>
Co-authored-by: Tao Zhu <tao@solana.com>
tao-stones added a commit that referenced this pull request Mar 13, 2024
…133) (#142)

* add precompile signature metrics to cost tracker (#133)

(cherry picked from commit 9770cd9)

# Conflicts:
#	cost-model/src/cost_model.rs
#	cost-model/src/cost_tracker.rs

* merge fix

* fmt

---------

Co-authored-by: Tao Zhu <82401714+tao-stones@users.noreply.github.com>
Co-authored-by: Tao Zhu <tao@solana.com>
@HaoranYi HaoranYi mentioned this pull request Apr 8, 2024
anwayde pushed a commit to firedancer-io/agave that referenced this pull request Jul 23, 2024
…nza-xyz#133) (anza-xyz#143)

* add precompile signature metrics to cost tracker (anza-xyz#133)

(cherry picked from commit 9770cd9)

* merge fix

* fmt

---------

Co-authored-by: Tao Zhu <82401714+tao-stones@users.noreply.github.com>
Co-authored-by: Tao Zhu <tao@solana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes v1.18
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants