-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wire scheduler up to adjust actual loaded accounts size cost for committed transactions #1547
Wire scheduler up to adjust actual loaded accounts size cost for committed transactions #1547
Conversation
…itted transactions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with this code, and I don't see anything obviously touching accounts-db. @tao-stones, is there a guidance on what you'd like me to look at?
Also, I see this PR does new stuff if a feature gate is active, but I don't see a new feature gate in this PR. That implies to me there's already an existing feature gate issue. Can you update the PR description to include the issue number and label (if you edit the PR description, you'll see them as comments at the bottom)? This will help me with the additional context. Thanks!
My apology - meant to add @bw-solana to this PR |
ca3c4f7
to
cdde7a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Problem
Transaction may set
loaded_accounts_data_size
limit, or uses default limit, that is higher than it actually loads. When cost model starts to "charge"CU
for loaded accounts data size, it is necessary to adjust block space transaction reserved with accounts size it actually loaded, alone with "executed CU" adjustment.Summary of Changes
loaded_accounts_data_size
toCommitted
enum variance.loaded_accounts_data_size_cost
to cost_tracker adjustment logic inupdate_execution_cost()
Note
Function of "charging CU for loaded accounts" logic is still behind
include_loaded_accounts_data_size_in_fee_calculation
gate, therefore this PR does not change Scheduler behavior until #1356Fixes #