-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multithreaded test infrastructure with Shuttle #1617
Conversation
instead of |
Do you mean another create in the monorepo? I need the shuttle imports across multiple crates, so a module in one of the existing ones wouldn't work I guess. |
Hmm, with some luck there's a crate that is imported by pretty much everything? sdk? :D |
That would surely work, but enforcing people to use the right import would be difficult. |
wouldn't be more difficult than making them import shuttle? |
Fair point. There are drawbacks in both approaches. On one hand, people may forget to add the shuttle import, on the other, they may still import from |
Closing this PR in favor of #1634. |
Problem
The program cache has multiple synchronization mechanisms without any systemic test infrastructure. Although PR #1471 introduced an adhoc test for program cache, it is insufficient for finding issues in the code.
Summary of Changes
I want to adopt shuttle to run specialized multithreaded test in the CI. In order for it to work, all
sync
,rand
andthread
imports must come fromshuttle
.