-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[anza migration] Sets client id to Agave #163
Conversation
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #163 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 838 838
Lines 226564 226568 +4
=======================================
+ Hits 185522 185559 +37
+ Misses 41042 41009 -33 |
thank you 🫶 lgtm but I would like to wait for others' insight! |
@willhickey Is this the right incantation to prevent this commit from getting sync'd back to the Labs's repo? |
Yes. I hadn't settled on a string yet, but |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(cherry picked from commit 0f1ca20)
(cherry picked from commit 0f1ca20)
Problem
The Agave fork still sets the client ID as "SolanaLabs", even though everything else (crates, binaries, etc) has migrated.
Summary of Changes
Set the client id to Agave.