Extract define-syscall crate #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
define-syscall-crate
branch
3 times, most recently
from
2158e14 to
7a7a0e1
Compare
joncinque
reviewed
Jun 27, 2024
joncinque
previously approved these changes
Jun 27, 2024
|
@yihau can you accept the crate ownership? 🙌 |
|
@kevinheavey sure! added! |
kevinheavey
force-pushed
the
define-syscall-crate
branch
from
563f7d4 to
c99b289
Compare
kevinheavey
added
the
automerge
kevinheavey
force-pushed
the
define-syscall-crate
branch
from
c99b289 to
67f4ae1
Compare
anza-team
removed
the
automerge
|
😱 New commits were pushed while the automerge label was present. |
kevinheavey
force-pushed
the
define-syscall-crate
branch
from
67f4ae1 to
bdc8d2c
Compare
joncinque
approved these changes
Jul 2, 2024
joncinque
added
the
automerge
samkim-crypto
pushed a commit
to samkim-crypto/agave
that referenced
this pull request
Jul 31, 2024
* move define_syscall macro to its own crate * use solana-define-syscall in solana-poseidon * add missing dep to solana-program * update crate version to match workspace * macro hygiene fix * fix define_syscall call * re-export sys_hash in solana-program for backwards compatibility * convert tabs to spaces * put re-export behind #[cfg(target_feature = "static-syscalls")]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
static-syscallspartSummary of Changes
solana_define_syscall::define_syscallin solana-poseidon