-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.18: ci: skip spl test when version is too high (backport of #1945) #1960
Conversation
Cherry-pick of 4d9d27f has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I made some comments about why this is needed on the v2.0 BP PR, those comments apply here as well except that v1.18 CI is actually broken without this change.
Lastly, as @yihau pointed out in #1960 (comment), we can see that the check is working as intended here on the v1.18 branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs rebase?
(cherry picked from commit 4d9d27f) # Conflicts: # .github/workflows/downstream-project-spl.yml
Yeah, we should be able to get all greens with rebase. I was hesitant to rebase it and make my ship it not count towards the two necessary to push, but let's rebase and we can voluntell one more reviewer. Edit: Oh wait, I forgot; rebase won't clear the reviews! |
1f2ebfc
to
de4184d
Compare
Yeah, I always forget this too! It's nice that github has gotten more rational in this one case. |
Problem
it makes no sense to run spl tests with lower version. actually we did it before but the logic missed accidentally. solana-labs#27326
Summary of Changes
stop running spl tests when it bump to higher version
This is an automatic backport of pull request #1945 done by Mergify.