Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.17: [anza migration]: add 'agave=info' to default log level (backport of #223) #242

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Mar 14, 2024

Problem

agave-validator's log doesn't print to file due to I don't set a proper default log level for it.

Summary of Changes

use solana=info,agave=info as our default log level filter.


cc @willhickey


This is an automatic backport of pull request #223 done by [Mergify](https://mergify.com).

@mergify mergify bot added the conflicts label Mar 14, 2024
@mergify mergify bot assigned yihau Mar 14, 2024
Copy link
Author

mergify bot commented Mar 14, 2024

Cherry-pick of 51dc7e6 has failed:

On branch mergify/bp/v1.17/pr-223
Your branch is up to date with 'origin/v1.17'.

You are currently cherry-picking commit 51dc7e6fb7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   bench-tps/src/main.rs
	modified:   dos/src/main.rs
	modified:   faucet/src/bin/faucet.rs
	modified:   gossip/src/main.rs
	modified:   ledger-tool/src/main.rs
	modified:   logger/src/lib.rs
	modified:   runtime/store-tool/src/main.rs
	modified:   scripts/run.sh
	modified:   transaction-dos/src/main.rs
	modified:   validator/src/lib.rs
	modified:   watchtower/src/main.rs

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   cargo-registry/src/main.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@yihau
Copy link
Member

yihau commented Mar 14, 2024

would like to include #245 with this backport

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 81.6%. Comparing base (3809dc0) to head (bfccb11).

Additional details and impacted files
@@            Coverage Diff            @@
##            v1.17     #242     +/-   ##
=========================================
- Coverage    81.6%    81.6%   -0.1%     
=========================================
  Files         806      806             
  Lines      219203   219205      +2     
=========================================
- Hits       178978   178945     -33     
- Misses      40225    40260     +35     

@yihau
Copy link
Member

yihau commented Mar 15, 2024

will have #245 in a separated PR

@yihau yihau merged commit af153cb into v1.17 Mar 18, 2024
32 checks passed
@yihau yihau deleted the mergify/bp/v1.17/pr-223 branch March 18, 2024 05:13
@HaoranYi HaoranYi mentioned this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants