Update PoH speed check to derive rate from Bank #2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PoH speed check currently determines the target hash rate by reading values from genesis. However, the hashes per tick rate has been increased via feature gates. Thus, the speed check is using a slower hash rate for comparison than what is actually active. So, update the PoH speed check to derive PoH hash rate from a Bank instead.
steviez
commented
Aug 5, 2024
core/src/validator.rs
Outdated
| let hashes_per_slot = hashes_per_tick * ticks_per_slot; | ||
| let hash_samples = maybe_hash_samples.unwrap_or(hashes_per_slot); | ||
|
|
||
| let hash_time = compute_hash_time(hash_samples); | ||
| let my_hashes_per_second = (hash_samples as f64 / hash_time.as_secs_f64()) as u64; | ||
| let target_slot_duration = Duration::from_nanos(genesis_config.ns_per_slot() as u64); | ||
|
|
||
| let target_slot_duration = Duration::from_nanos(bank.ns_per_slot as u64); |
There was a problem hiding this comment.
Not really sure ns_per_slot should be public in Bank, but seemingly a refactor for after this:
Line 730 in 4e5af1e
Comment on lines
-2944
to
+2959
| target_tick_duration: Duration::from_millis(solana_sdk::clock::MS_PER_TICK), | ||
| target_tick_duration: target_tick_duration(), |
There was a problem hiding this comment.
Technically, this change isn't critical for the PR. But, the constant MS_PER_TICK is 6ms; 6 ms/tick * 64 ticks/slot = 384 ms/slot. It annoyed me that this didn't come out to the 400ms, and I noticed when observing the info log from speed check. Can revert it back if desired
bw-solana
reviewed
Aug 5, 2024
bw-solana
previously approved these changes
Aug 5, 2024
steviez
commented
Aug 6, 2024
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
The PoH speed check currently determines the target hash rate by reading values from genesis. However, the hashes per tick rate has been increased via feature gates. Thus, the speed check is using a slower hash rate for comparison than what is actually active. So, update the PoH speed check to derive PoH hash rate from a Bank instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The PoH speed check currently determines the target hash rate by reading values from genesis. However, the hashes per tick rate has been increased via feature gates. Thus, the speed check is using a slower hash rate for comparison than what is actually active.
Summary of Changes
So, update the PoH speed check to derive PoH hash rate from a Bank instead.
Running this on MNB, I see the following log emitted:
10 million is the correct value; the log output shared in my previous PR (#2400) will show that we were previously showing 2 million as the target.