Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElGamal: add From impls; deprecate from/to_bytes #246

Merged
merged 5 commits into from
Apr 4, 2024

Conversation

abcalphabet
Copy link

Problem

TryFrom and From should be used instead of from_bytes and to_bytes.

As per the discussion on PR #208

Summary of Changes

Deprecates from_bytes and to_bytes in favor of try_from and into

Fixes #

@samkim-crypto samkim-crypto self-requested a review March 17, 2024 01:57
@samkim-crypto samkim-crypto added the CI Pull Request is ready to enter CI label Mar 17, 2024
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Mar 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 81.8%. Comparing base (79e316e) to head (68e3235).
Report is 30 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master     #246    +/-   ##
========================================
  Coverage    81.8%    81.8%            
========================================
  Files         843      846     +3     
  Lines      228586   228938   +352     
========================================
+ Hits       187124   187427   +303     
- Misses      41462    41511    +49     

@samkim-crypto samkim-crypto added the CI Pull Request is ready to enter CI label Mar 24, 2024
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Mar 24, 2024
@samkim-crypto samkim-crypto added the CI Pull Request is ready to enter CI label Apr 3, 2024
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Apr 3, 2024
@samkim-crypto samkim-crypto merged commit 855a0c1 into anza-xyz:master Apr 4, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants