-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: programs.md #2908
docs: programs.md #2908
Conversation
Enhance the documentation of the Native Programs Problem Poor documentation and wrong grammar (sometimes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks for contributing! I didn't really agree with some of your suggested changes, so I left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of fly-by comments, otherwise, agreed with @buffalojoec's comments
c2cedf7
to
23f11e3
Compare
Thank you for your reviews and corrections, @buffalojoec and @joncinque! I've addressed your (legit!) findings - and pushed the new changes to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of last things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Oh actually I can't merge since I was the last committer, @buffalojoec can you approve? 😅 |
Enhance the documentation of the Native Programs
Problem
Poor documentation and wrong grammar