Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: programs.md #2908

Merged
merged 5 commits into from
Sep 13, 2024
Merged

docs: programs.md #2908

merged 5 commits into from
Sep 13, 2024

Conversation

IaroslavMazur
Copy link

Enhance the documentation of the Native Programs

Problem
Poor documentation and wrong grammar

Enhance the documentation of the Native Programs

Problem
Poor documentation and wrong grammar (sometimes)
Copy link

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for contributing! I didn't really agree with some of your suggested changes, so I left some comments.

docs/src/runtime/programs.md Outdated Show resolved Hide resolved
docs/src/runtime/programs.md Outdated Show resolved Hide resolved
docs/src/runtime/programs.md Outdated Show resolved Hide resolved
docs/src/runtime/programs.md Outdated Show resolved Hide resolved
docs/src/runtime/programs.md Outdated Show resolved Hide resolved
docs/src/runtime/programs.md Outdated Show resolved Hide resolved
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of fly-by comments, otherwise, agreed with @buffalojoec's comments

docs/src/runtime/programs.md Outdated Show resolved Hide resolved
docs/src/runtime/programs.md Outdated Show resolved Hide resolved
@IaroslavMazur
Copy link
Author

Thank you for your reviews and corrections, @buffalojoec and @joncinque!

I've addressed your (legit!) findings - and pushed the new changes to the PR.

Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of last things

docs/src/runtime/programs.md Outdated Show resolved Hide resolved
docs/src/runtime/programs.md Outdated Show resolved Hide resolved
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@joncinque
Copy link

Oh actually I can't merge since I was the last committer, @buffalojoec can you approve? 😅

@buffalojoec buffalojoec merged commit d7de94c into anza-xyz:master Sep 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants