Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract serialize-utils crate #2926

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

kevinheavey
Copy link

Problem

solana_program::serialize_utils is a blocker for pulling out solana_program::sysvar and solana_program::vote

Summary of Changes

Move it to its own crate and re-export with deprecation

Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one bit, but the rest looks great!

sdk/serialize-utils/Cargo.toml Outdated Show resolved Hide resolved
@joncinque
Copy link

@yihau can you accept the ownership for solana-serialize-utils once it's passed over?

Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approve once the crate check passes, looks good to me!

@kevinheavey kevinheavey added the automerge automerge Merge this Pull Request automatically once CI passes label Sep 25, 2024
@yihau
Copy link
Member

yihau commented Sep 25, 2024

all green!

@mergify mergify bot merged commit 66b9926 into anza-xyz:master Sep 25, 2024
53 checks passed
@kevinheavey kevinheavey deleted the serialize-utils-crate branch October 3, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes need:merge-assist
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants