Extract program-pack crate #2930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
extract-program-pack
branch
2 times, most recently
from
21928ff
to
9055432
Compare
febo
reviewed
Oct 3, 2024
febo
reviewed
Oct 3, 2024
|
@yihau CI failures are unrelated so I've sent a crate ownership invite to anza-team |
febo
previously approved these changes
Oct 3, 2024
febo
reviewed
Oct 3, 2024
kevinheavey
added
the
automerge
|
automerge label removed due to a CI failure |
mergify
bot
removed
the
automerge
kevinheavey
force-pushed
the
extract-program-pack
branch
from
0a156b9
to
3f15fa6
Compare
kevinheavey
added
the
automerge
febo
approved these changes
Oct 4, 2024
kevinheavey
added
automerge
|
@febo could you merge this please? I don't have write access - usually automerge works for me but not today it seems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
Packtrait imposes asolana_programrequirement on many programs, most notably in the SPLSummary of Changes
Move
program_pack.rsto its own crate and re-export with deprecationThis branches off #2413 so that needs to be merged first