Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump blake3 1.5.1 -> 1.5.4 #2959

Merged
merged 3 commits into from
Sep 24, 2024
Merged

bump blake3 1.5.1 -> 1.5.4 #2959

merged 3 commits into from
Sep 24, 2024

Conversation

4r33x
Copy link

@4r33x 4r33x commented Sep 20, 2024

Problem

New Rust crates with blake3 version greater than 1.5.1 cannot be used with solana-program crate due to the removal of the implicit "digest" feature in version 1.5.2 of blake3.
Also new version comes with perf improvements:
1.5.4

Initial implementation of SIMD acceleration for the XOF (i.e.
blake3::Hasher::finalize_xof). This brings long output performance
into line with long input performance. Currently AVX-512-only and Unix-only.

Summary of Changes

  1. Change blake3 = "1.5.1" to blake3 = "1.5.4" in root Cargo.toml
  2. Remove redundant feature "digest"in blake3 in solana program Cargo.toml

Fixes #

@mergify mergify bot requested a review from a team September 20, 2024 23:21
@yihau yihau added the CI Pull Request is ready to enter CI label Sep 23, 2024
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Sep 23, 2024
@yihau
Copy link
Member

yihau commented Sep 23, 2024

thank you for your contribution! could you run ./scripts/cargo-for-all-lock-files.sh tree and commit the changes? we have 2 cargo.lock need to be aligned.

@4r33x
Copy link
Author

4r33x commented Sep 23, 2024

thank you for your contribution! could you run ./scripts/cargo-for-all-lock-files.sh tree and commit the changes? we have 2 cargo.lock need to be aligned.

Done C:

@yihau yihau added the CI Pull Request is ready to enter CI label Sep 24, 2024
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Sep 24, 2024
yihau
yihau approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@yihau yihau merged commit 6b9f569 into anza-xyz:master Sep 24, 2024
54 checks passed
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
@4r33x @ray-kast
bump blake3 1.5.1 -> 1.5.4 (anza-xyz#2959)
8b42328 
* bump blake3 1.5.1 -> 1.5.4

* bump blake3 1.5.1 -> 1.5.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihau yihau yihau approved these changes

Assignees
No one assigned
Labels
community need:merge-assist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@4r33x @yihau @anza-team